Quoting James Almer (2021-02-26 19:59:57) > > LGTM. > > Also, FWIW, this is not flushing the encoder (It wasn't before this > patch either). For being an API test it's not exactly using it right, > but it doesn't really matter here since for FLAC, flushing the encoder > will return a side data only packet with an updated stream header info > and not any delayed/buffered packet, and this test only cares about > comparing the raw pcm audio pre encoding and post decoding.
I agree that this tests makes a bit too many assumptions, but I didn't want to rewrite everything, since I'd like to actually get to the bump reasonably soon. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
