On Tue, 2 Mar 2021, Peter White wrote:
On 02.03.21 17:56, James Almer wrote:
On 3/2/2021 1:25 PM, Peter White wrote:
Sorry, apparently patches need to be sent inline, I just noticed.
Please excuse my ignorance.
They don't need to be inline, although it is preferred. What they need
to be is made with git format-patch, which preserves authorship
information and commit message.
Thanks for your explanation. Hopefully now it is OK.
Also, the commit message should be descriptive of what it fixes, and not
only reference a ticket number.
Like this?
Well, yes and no. If you want to send inline patches, then only the patch
as generated by git format-patch should be your mail, and no line wrapping
should occur because that corrupts the patch. Copy-pasting the patch to a
regular mail client does not work (a regular mail client wraps lines, eats
up whitespace, etc), so I think most people just use git send-email.
If you can't or won't use that, then sending the patch as attachment is
the safer bet to avoid patch corruption. Many people does that, even if
that is not what we generally prefer.
Regards,
Marton
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
