On Thu, Apr 16, 2015 at 09:25:26PM +0200, Andreas Cadhalpun wrote: > This fixes an invalid read if end is 0: > band_end = ff_ac3_bin_to_band_tab[end-1] + 1; > > Depending on what is before the array, this can cause stack smashing, > when band_end becomes too large. > > Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> > --- > libavcodec/ac3.c | 3 +++ > 1 file changed, 3 insertions(+)
i think it would be better to (also) error out earlier when end_freq would not be set to a valid value but checking in ff_ac3_bit_alloc_calc_mask() is possibly more robust so applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB He who knows, does not speak. He who speaks, does not know. -- Lao Tsu
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
