Quoting James Almer (2021-08-09 05:45:09)
> On 8/8/2021 2:29 PM, Anton Khirnov wrote:
> > +int sws_frame_start(struct SwsContext *c, AVFrame *dst, const AVFrame *src)
> > +{
> > +    int ret, allocated = 0;
> > +
> > +    ret = av_frame_ref(c->frame_src, src);
> > +    if (ret < 0)
> > +        return ret;
> > +
> > +    if (!dst->buf[0]) {
> 
> The frame could have non refcounted buffers, and av_frame_get_buffer() 
> below would overwrite the data pointers.
> IMO, just state in the doxy that if already allocated, the data buffers 
> must be reference counted.

Ok, will do. I don't think there's any reason to support non-refcounted
frames anymore.

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Reply via email to