Soft Works (12021-08-30): > v2 Update: > > - Implemented Andreas' suggestions > - overlay_subs filter: > - removed duplicated code > - implemented direct (no pre-conversion) blending of graphical > subtitle rects > - Supported input formats: > - all packed RGB formats (with and without alpha) > - yuv420p, yuv422p, yuv444p > > > This patchset is about introducing filtering support for subtitles.
Rejected. As I have explained to you, no subtitle support can be accepted until the negotiation process has been refactored to make adding a third media type less of a nightmare. From your questions and remarks in other discussions, it seems obvious to me that you are missing something central about the format negotiation. That makes discussion with you at cross-purpose, a waste of your efforts and ours both, and that makes your patches unacceptable. So, if you really want to contribute, I strongly suggest you stop insisting on what you already wrote, and take the time to read the code in depth to understand how it works and how it needs to be made better. Then you can prove to yourself your understanding by submitting FATE tests for the parts that are not yet covered, as I suggested recently. -- Nicolas George
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
