On Fri, Sep 17, 2021 at 01:10:33AM +0300, Jan Ekström wrote: > On Thu, Sep 16, 2021 at 1:55 PM <lance.lmw...@gmail.com> wrote: > > > > From: Limin Wang <lance.lmw...@gmail.com> > > > > Signed-off-by: Limin Wang <lance.lmw...@gmail.com> > > --- > > For the record, Christopher Degawa also posted something similar > (https://patchwork.ffmpeg.org/project/ffmpeg/patch/20210310224859.1726693-1-c...@randomderp.com/),
I think It's very confusing for the configure for crf, it's 0 as cqp, user had to enable_tpl_la and configure crf also. So I prefer to my proposal. > and I finally recently had gotten to noting on IRC that the rate > control options should be brought more in line with, say, libx264. Set > AVOption-specific defaults (f.ex., libx264 sets CRF to its default > value by default), and then if any of the other rate control modes is > nonzero the appropriate rate control would get utilized in the > wrapper. As rate control options is supported already, so it's better to make crf mode works also. User can use AVOption-specific if can working as expect in future. If CRF is preferable default, I can change the default crf value to 50 instead of -1. > > Jan > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". -- Thanks, Limin Wang _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".