> -----Original Message----- > From: ffmpeg-devel <ffmpeg-devel-boun...@ffmpeg.org> On Behalf Of > Andreas Rheinhardt > Sent: Wednesday, 29 September 2021 10:28 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v2 1/1] avfilter/frames: Ensure > frames are writable when processing in-place > > Soft Works: > > > > > >> -----Original Message----- > >> From: ffmpeg-devel <ffmpeg-devel-boun...@ffmpeg.org> On Behalf Of > >> James Almer > >> Sent: Tuesday, 28 September 2021 22:08 > >> To: ffmpeg-devel@ffmpeg.org > >> Subject: Re: [FFmpeg-devel] [PATCH v2 1/1] avfilter/frames: Ensure > >> frames are writable when processing in-place > >> > >> On 9/28/2021 4:54 PM, Soft Works wrote: > >>> Signed-off-by: softworkz <softwo...@hotmail.com> > >>> --- > >>> v2: Reduced to cases without AVFILTERPAD_FLAG_NEEDS_WRITABLE > >> > >> Can't this flag used in these filters? > > > > I mentioned before that I don’t consider this as a good API > > design. It had even caused a review of my subtitle filters to > > assume that my filter code would be incorrect, even though I > > had been using that flag. > > Would you please provide a reference for this? Especially after what > you > said on IRC I have to presume that this refers to my review of your > textmod filter [1] contained in v5 of your patches. Yet you did not > use > said flag in this patch at all (you seem to have never used that flag > in > any of your patches); in fact, using that flag would not have worked > at > all, as it was only v6 which added support for making subtitle frames > writable in ff_inlink_make_frame_writable(). In v5, not even > av_frame_make_writable() would have worked, as I have explained to > you > in [2].
I apologize when I mixed up one or two details, that I had memorized differently. Though, it still illustrates why I'm saying that the existence of that flag is causing unnecessary confusion for minimal benefit. Kind regards, softworkz _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
