> +#if (GNU_PROPERTY_AARCH64_BTI != 0) > + .pushsection .note.gnu.property, "a"; > + .balign 8; > + .long 4; > + .long 0x10; > + .long 0x5; > + .asciz "GNU"; > + .long 0xc0000000; /* GNU_PROPERTY_AARCH64_FEATURE_1_AND */ > + .long 4; > + .long GNU_PROPERTY_AARCH64_BTI; > + .long 0 > + .popsection
The trailing semicolons here are superfluous. They'd be needed if stacking all of it on one single line, but as it's split over multiple lines (which I like), it's not needed, so I'd suggest removing them. Also, I'd prefer to have these directives indented in the same way as the rest of main directives in the file, i.e. with 8 leading spaces. > +#endif > + > .macro function name, export=0, align=2 > .macro endfunc > ELF .size \name, . - \name > @@ -49,6 +78,7 @@ FUNC .endfunc > ELF .type EXTERN_ASM\name, %function > FUNC .func EXTERN_ASM\name > EXTERN_ASM\name: > + AARCH64_VALID_CALL_TARGET > .else I'd also prefer to have this aligned one step deeper, along with the .size/.type/.func above. I can make these hopefully innocent changes before pushing, if that's ok with you. If you want to try out the modifications, my version, ready to be pushed, is available at https://github.com/mstorsjo/FFmpeg/commits/aarch64-bti. Thanks for picking these up, Martin. Your modified version of the change looks fine to push - no issues when tested on our BTI-enabled test environment. Thanks, Jonathan IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
