On Thu, Nov 18, 2021 at 05:30:50AM +0100, Andreas Rheinhardt wrote:
> lance.lmw...@gmail.com:
> > From: Limin Wang <lance.lmw...@gmail.com>
> >
> > Signed-off-by: Limin Wang <lance.lmw...@gmail.com>
> > ---
> > libavfilter/vf_gblur_vulkan.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libavfilter/vf_gblur_vulkan.c b/libavfilter/vf_gblur_vulkan.c
> > index d4f391b..16c8bbb 100644
> > --- a/libavfilter/vf_gblur_vulkan.c
> > +++ b/libavfilter/vf_gblur_vulkan.c
> > @@ -124,7 +124,7 @@ static av_cold void
> > init_gaussian_params(GBlurVulkanContext *s)
> >
> > static av_cold int init_filter(AVFilterContext *ctx, AVFrame *in)
> > {
> > - int err;
> > + int err = 0;
> > char *kernel_def;
> > uint8_t *kernel_mapped;
> > FFSPIRVShader *shd;
> >
>
> I don't see an uninitialized value at all: It is directly initialized in
> some error paths and if not, it is initialized in the RET() macro. And
> in any case it would be better to zero ret directly above the "fail:"
> because then this function always returns zero on success even if the
> last function called could return values > 0.
yes, but it's very difficult to check out all place are initialized for all
errors, so I think it's better to make it initialized. By your comments,
I think it's more better to initialized to zero before failed, I'll resubmit
a patch.
>
> - Andreas
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
--
Thanks,
Limin Wang
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
