20 Dec 2021, 17:59 by mich...@niedermayer.cc:
> On Mon, Dec 20, 2021 at 11:15:08AM +0100, Lynne wrote:
>
>> Recently, Metal support was merged, which is autodetected
>> by default. Metal doesn't even have a hwcontext and it's not
>> a hwaccel, nor would it likely ever be one as Apple won't drop
>> videotoolbox.
>>
>> To keep it fair, autodetect Vulkan, which is a hwcontext,
>> and for which there is an unmerged hwaccel patch.
>>
>> Patch attached.
>>
>> configure | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>> 09c6bfd367bd2ac897abc5716e2e9605341036cd
>> 0001-configure-autodetect-vulkan.patch
>> From 1f5243450242039f82a91e7eccb724af4b6ef37c Mon Sep 17 00:00:00 2001
>> From: Lynne <d...@lynne.ee>
>> Date: Mon, 20 Dec 2021 11:04:49 +0100
>> Subject: [PATCH] configure: autodetect vulkan
>>
>
> breaks build here on ubuntu
>
> ./configure
> ERROR: defined VK_VERSION_1_2 not satisfied
>
> If you think configure made a mistake, make sure you are using the latest
> version from Git. If the latest version fails, report the problem to the
> ffmpeg-u...@ffmpeg.org mailing list or IRC #ffmpeg on irc.libera.chat.
> Include the log file "ffbuild/config.log" produced by configure as this will
> help
> solve the problem.
>
Thanks for testing, V2 attached, just changes require_cpp to check_cpp,
since autodetecting is not a hard-require unlike enabling libraries.
>From 57086023a05a981609f68f7760e1398b3211e0ab Mon Sep 17 00:00:00 2001
From: Lynne <d...@lynne.ee>
Date: Mon, 20 Dec 2021 11:04:49 +0100
Subject: [PATCH v2] configure: autodetect vulkan
---
configure | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/configure b/configure
index d8b07c8e00..3be4de61e0 100755
--- a/configure
+++ b/configure
@@ -324,7 +324,7 @@ External library support:
--disable-securetransport disable Secure Transport, needed for TLS support
on OSX if openssl and gnutls are not used [autodetect]
--enable-vapoursynth enable VapourSynth demuxer [no]
- --enable-vulkan enable Vulkan code [no]
+ --disable-vulkan enable Vulkan code [autodetect]
--disable-xlib disable xlib [autodetect]
--disable-zlib disable zlib [autodetect]
@@ -1896,6 +1896,7 @@ HWACCEL_AUTODETECT_LIBRARY_LIST="
vaapi
vdpau
videotoolbox
+ vulkan
v4l2_m2m
xvmc
"
@@ -1918,7 +1919,6 @@ HWACCEL_LIBRARY_LIST="
mmal
omx
opencl
- vulkan
"
DOCUMENT_LIST="
@@ -6914,7 +6914,7 @@ enabled crystalhd && check_lib crystalhd "stdint.h libcrystalhd/libcrystalhd_if.
if enabled vulkan; then
check_pkg_config_header_only vulkan "vulkan >= 1.2.189" "vulkan/vulkan.h" "defined VK_VERSION_1_2" ||
- require_cpp_condition vulkan "vulkan/vulkan.h" "defined VK_VERSION_1_2"
+ check_cpp_condition vulkan "vulkan/vulkan.h" "defined VK_VERSION_1_2"
fi
if enabled x86; then
--
2.34.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
