On Tue, Jun 09, 2015 at 10:44:08PM +0200, Andreas Cadhalpun wrote: > On 09.06.2015 22:30, Michael Niedermayer wrote: > > On Tue, Jun 09, 2015 at 10:22:05PM +0200, Andreas Cadhalpun wrote: > >> avctx->channels can be 0, causing SIGFPE crashes. > >> > >> Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> > >> --- > >> libavcodec/sonic.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > > > > i think avctx->channels should be set, channels is only set during > > init and cannot change per frame in sonic > > maybe avctx->channels could be set during init > > Yes, that's way better, because it actually allows decoding such samples. > New patch attached. > > Best regards, > Andreas >
> sonic.c | 1 + > 1 file changed, 1 insertion(+) > 3eb2f8fa1f33a5d4ab0434d45a1d584b1774fa3a > 0001-sonic-set-avctx-channels-in-sonic_decode_init.patch > From 489bc2758317c5534ae1292c3f772e0dc870d0e4 Mon Sep 17 00:00:00 2001 > From: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> > Date: Tue, 9 Jun 2015 22:41:24 +0200 > Subject: [PATCH] sonic: set avctx->channels in sonic_decode_init > > Otherwise it can be 0 in sonic_decode_frame causing SIGFPE crashes. LGTM thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Freedom in capitalist society always remains about the same as it was in ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
