Wujian(Chin) (12022-12-24): > This code simplicity does not affect the readability and > maintainability of the program
You are not the one who maintain them, that is not your judgement. > The mask effect is like this：ffmpeg -mask_url -i rtsp://tyyy.com --> ffmpeg > -mask_url -i *************** I know, it was obvious from the start. > > this way you miss credentials passed through options. > I still don't understand. Can you go into more detail? Look up cryptokey in the documentation for example. > >> >sizeof(*argv2) > Sorry, I didn't get it. This is elementary C and a staple of FFmpeg's coding style. > I understand that mask_url needs to be placed first, And that is an unacceptable misfeature. > because the FFmpeg process of the ps -ef command is viewed as argv, That is nonsense. > Therefore, you need to copy argv to argv_copy immediately, mask the URL in > the argv, > and then argv_copy is a command without mask_url for the following programs. The few milliseconds of the normal options parsing will not make a difference. > I don't understand the difference between the normal option and the mask_url > in use? Your version is a special case that needs to be maintained. That is only acceptable with a very good reason, and you have not provided one. > Looking forward to your reply, thank you. Let me be clear: this here is a review of your code, not a tutorial on becoming a better developer, and even less "what an excellent idea, let us do the work for you". -- Nicolas George
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
