On 3/13/2023 5:23 PM, Raphaël Zumer wrote:
Signed-off-by: Raphaël Zumer <rzu...@tebako.net> --- doc/APIchanges | 5 ++ libavutil/hdr_dynamic_metadata.c | 146 +++++++++++++++++++++++++++++++ libavutil/hdr_dynamic_metadata.h | 12 +++ libavutil/version.h | 2 +- 4 files changed, 164 insertions(+), 1 deletion(-)
The serialization code here looks almost the same as the one submitted some time ago by Mohammad Izadi in https://patchwork.ffmpeg.org/project/ffmpeg/patch/20220908012214.1556959-1-iz...@google.com/ He in fact used the (int)(const AVDynamicHDRPlus* s, uint8_t** data, size_t* size) signature for the function which does look more versatile as it allows the return of error codes, fwiw.
IMO, this patch should either have him as co-author, or a line added to the commit message mentioning that it's based on his work.
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
