> it passes fate but seems to crash for example with:
> ./ffmpeg -i lena.pnm  -vf format=gbrp test.avi
>
I'll check it.

how /over what did you meassure the 3% exactly ?
> iam asking, so i understand if this performance chnage is irrelevant
> or not.
> for init code that runs once some speed loss is irrelevant but for
> example the horizontal scale code as a whole should not become 3%
> slower.
> but i do not suggest to do non trivial optimization on this yet.
> better get it all working first.

The measurement was done only for the horizontal scaling loop.
But it should improve without much effort  when the implementation advance.

please always attach patches, that makes reviewing them with with
> MUAs easy and also keeps them together with any discussions about
> them. who knows if the github links will still work in 10 years if
> someone tries to debug something and tried to look up old discussions
> and patches ...
>
Attached.

Attachment: 0001-Add-gamma-encodign-decoding-before-after-scaling-in-.patch
Description: Binary data

Attachment: 0002-swscale-refactor-added-initial-filters.patch
Description: Binary data

Attachment: 0003-FIXES.patch
Description: Binary data

Attachment: 0004-swscale-move-variable-filter-attributes-to-filter-in.patch
Description: Binary data

Attachment: 0005-swscale-rename-instance-structs.patch
Description: Binary data

Attachment: 0006-swscale-corrected-chroma-sliceY-sliceH.patch
Description: Binary data

Attachment: 0007-swscale-initial-horizontal-chroma-scaling-work.patch
Description: Binary data

Attachment: 0008-swscale-plug-chroma-horizontal-scaling.patch
Description: Binary data

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Reply via email to