On Thu, 13 Jul 2023, Logan.Lyu wrote:

Hi, Martin,

Thanks for your comments.

I have now amended the unreasonable parts of ldp/stp that I have seen.  And I updated patch 3 and patch 5. (Although I have attached all 5 patches) In addition, I thought that q8-q15 was required to be saved according to the calling convention before, but later I confirmed that it is the lower 64bit, thank you for reminding.

Please take a look. If there are some small mistakes, please correct them directly. If there are still many problems, please remind me again, thank you!

Thanks, this looks mostly good to me!

In patch 3, there was still one case of a missing comma between macro arguments, that I fixed. I also included the checkasm benchmark numbers in the commit messages - please remember to add them for future patches.

I'll push these patches later after a bit more testing, if that testing doesn't show any further issues. Thanks!

// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Reply via email to