Thanks for the reply; I wasn't looking to merge the RFC as-is, but rather to
figure out the preferred approach, and most importantly make sure that there is
no fundamental disagreement on suppressing codec-level metadata in situations
where it conflicts with format-level.
I will see which of the alternative implementations comes out cleaner
(*probably* a separate function due to the multiple call locations) and either
send a v2 RFC patch or separate set later.
Raphaël Zumer
On 7/25/23 14:53, Anton Khirnov wrote:
Quoting Vittorio Giovara
Any comments on this patch? If no objections I'd like to push it at the end
of the week
Sorry, not acceptable. This is the wrong place to do it.
AVCodecParameters is a dumb container for parameters. It MUST NOT make
any assumptions about who calls it or for what purpose. The caller tells
it to copy data - it copies data.
Sadly I don't have the time to think about this in depth right now (ask
me again in 3 weeks or so), but some potential alternatives:
* handle this explicitly in the caller
* add a new function, say avcodec_parameters_update(), perhaps with a
flags parameter controlling how exactly is the update to be performed;
not entirely sure this generalizes well enough
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
