On So, 2023-08-06 at 19:54 +0800, Ting Hu wrote: > From: tinghu3 <siriu...@hotmail.com> > > In order to save bandwith for video conference application, > set pic_timing_sei of av_option to disable SEI frames. > It doesn't take effect. > > Signed-off-by: tinghu3 <siriu...@hotmail.com> > --- > libavcodec/qsvenc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c > index df63c182b0..7a5ea5391e 100644 > --- a/libavcodec/qsvenc.c > +++ b/libavcodec/qsvenc.c > @@ -937,7 +937,7 @@ static int init_video_param(AVCodecContext *avctx, > QSVEncContext *q) > q->extco.Header.BufferSz = sizeof(q->extco); > > q->extco.PicTimingSEI = q->pic_timing_sei ? > - MFX_CODINGOPTION_ON : > MFX_CODINGOPTION_UNKNOWN; > + MFX_CODINGOPTION_ON : > MFX_CODINGOPTION_OFF;
PicTimingSEI and RefPicMarkRep are tristate flags. When a tristate flag is set to MFX_CODINGOPTION_UNKNOWN(0), the SDK encoder can choose a best configuration based on the current state and settings. We want to the SDK encoder set reasonable values for these flags Thanks Haihao > q->old_pic_timing_sei = q->pic_timing_sei; > > if (q->rdo >= 0) > @@ -968,6 +968,7 @@ static int init_video_param(AVCodecContext *avctx, > QSVEncContext *q) > q->extco.AUDelimiter = q->aud ? MFX_CODINGOPTION_ON : > MFX_CODINGOPTION_OFF; > } > > + q->extco.RefPicMarkRep = q->pic_timing_sei ? MFX_CODINGOPTION_ON : > MFX_CODINGOPTION_OFF; > q->extparam_internal[q->nb_extparam_internal++] = (mfxExtBuffer *)&q- > >extco; > > if (avctx->codec_id == AV_CODEC_ID_H264) { _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".