On Fri, Sep 29, 2023 at 2:32 PM Hendrik Leppkes <h.lepp...@gmail.com> wrote: > > On Fri, Sep 29, 2023 at 3:55 PM Tristan Matthews <tma...@videolan.org> wrote: > > > > Fixes: https://trac.ffmpeg.org/ticket/10596 > > --- > > configure | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/configure b/configure > > index 20db1801ed..50ba6f772f 100755 > > --- a/configure > > +++ b/configure > > @@ -7154,7 +7154,8 @@ enabled crystalhd && check_lib crystalhd "stdint.h > > libcrystalhd/libcrystalhd_if. > > > > if enabled vulkan; then > > check_pkg_config_header_only vulkan "vulkan >= 1.3.255" > > "vulkan/vulkan.h" "defined VK_VERSION_1_3" || > > - check_cpp_condition vulkan "vulkan/vulkan.h" > > "defined(VK_VERSION_1_4) || (defined(VK_VERSION_1_3) && VK_HEADER_VERSION > > >= 255)" > > + check_cpp_condition vulkan "vulkan/vulkan.h" > > "defined(VK_VERSION_1_4) || (defined(VK_VERSION_1_3) && VK_HEADER_VERSION > > >= 255)" || > > + warn "Disabling vulkan" && disable vulkan > > fi > > > > This change doesn't seem right. If a feature is explicitly requested, > we generally fail the build and don't just disable the feature > (afterall the user wanted it to be on).
That is the case here, with or without this patch, on my system --enable-vulkan will fail as expected on: > ERROR: vulkan requested but not found The bug I'm trying to address is the autodetect case. I'm happy to drop the warning, I just wanted it to be obvious what was happening (but one could infer it from the list of modules that will be built). > If the feature is not > explicitly requested, then it should not print a message. > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
