Le mar. 31 oct. 2023 à 08:28, Michael Niedermayer <mich...@niedermayer.cc> a écrit : > > On Sun, Oct 29, 2023 at 08:05:50PM -0500, Romain Beauxis wrote: > > The logic for extracting HLS codec attribute strings is very useful and > > can be re-used in many different situations when working with HLS > > streams using libavcodec/libavformat. > > > > This patch extracts the function's code and places it into a publicly > > available function. > > > > --- > > libavcodec/Makefile | 2 + > > libavcodec/hls.c | 105 +++++++++++++++++++++++++++++++++++++++++++ > > libavcodec/hls.h | 42 +++++++++++++++++ > > libavformat/hlsenc.c | 83 +++------------------------------- > > you cannot call ff_* functions across libs > > they need to start with av* / avpriv*
Thanks for the review! Updated patch submitted. > [...] > > + rbsp_buf = ff_nal_unit_extract_rbsp(data, remain_size, > > &rbsp_size, 0); > > libavcodec/libavcodec.so: undefined reference to `ff_nal_unit_extract_rbsp' > clang: error: linker command failed with exit code 1 (use -v to see > invocation) > Makefile:133: recipe for target 'ffmpeg_g' failed > make: *** [ffmpeg_g] Error 1 > make: *** Waiting for unfinished jobs.... > libavcodec/libavcodec.so: undefined reference to `ff_nal_unit_extract_rbsp' > clang: error: linker command failed with exit code 1 (use -v to see > invocation) > Makefile:133: recipe for target 'ffplay_g' failed > make: *** [ffplay_g] Error 1 > > thx > > [...] > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > If a bugfix only changes things apparently unrelated to the bug with no > further explanation, that is a good sign that the bugfix is wrong. > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
