Le sam. 30 déc. 2023 à 16:25, David Johansen <davejohan...@gmail.com> a écrit : > > On Sat, Dec 30, 2023 at 8:23 AM Romain Beauxis <to...@rastageeks.org> wrote: >> >> Le jeu. 28 déc. 2023 à 17:26, David Johansen <davejohan...@gmail.com> a >> écrit : >> >> >> >> I love this change, but it appears that st->codecpar->profile is always >> >> AV_PROFILE_UNKNOWN when using libfdk_aac as the encoder. Any indications >> >> where I should look for fix that so this can be used with that encoder? >> > >> > >> > It appears that the issue is that profile doesn't default to what's being >> > used so `--profile:a` has to be set explicitly with libfdk_aac and then it >> > works. Not sure if that's an issue worth fixing, but if someone points me >> > to where it needs to be done, then I'd be glad to take a look at fixing it >> >> This feels like a second, separate issue to me? >> >> Maybe we could get these changes in first and then tackle it? > > > But this is technically a breaking change, because it takes commands/uses > that currently work and changes them to no longer include CODECS since the > profile value is unknown by default
Ha gotcha. Yes, in this case we do need to send the previous value as fallback when the profile is unknown. Just sent an updated patch! -- Romain _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
