Quoting Stefano Sabatini (2024-01-06 12:44:27) > On date Friday 2024-01-05 17:42:49 +0100, Anton Khirnov wrote: > > To be used for data that never needs to be visible outside of the > > demuxer thread, similarly as was previously done for other components. > > --- > > fftools/ffmpeg_demux.c | 67 ++++++++++++++++++++++++++++-------------- > > 1 file changed, 45 insertions(+), 22 deletions(-) > > > > diff --git a/fftools/ffmpeg_demux.c b/fftools/ffmpeg_demux.c > > index c51140b1c5..eae1f0bde5 100644 > > --- a/fftools/ffmpeg_demux.c > > +++ b/fftools/ffmpeg_demux.c > > @@ -115,6 +115,11 @@ typedef struct Demuxer { > > int nb_streams_finished; > > } Demuxer; > > > > > +typedef struct DemuxThreadContext { > > + // packet used for reading from the demuxer > > > + AVPacket *pkt_demux; > > nit: you might drop the _demux suffix since this is already clear from > the context and it's adding no information
I'm adding the suffix because a following commit adds another packet to the struct, so I prefer to make it clear what each one's role is. > > static void *input_thread(void *arg) > > { > > Demuxer *d = arg; > > InputFile *f = &d->f; > > - AVPacket *pkt; > > + > > + DemuxThreadContext dt; > > + > > nit++: weird style, you might drop the empty lines around the > declaration I prefer it this way. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".