On date Tuesday 2024-03-12 01:00:02 -0500, Marth64 wrote:
> In Closed Captions (US), the non-breaking space (0xA0) can be used to
> align text horizontally from the left when used as a leading character.
> However, CC decoder does not ignore it as a leading character
> like it does an ordinary space, so a blank padding is rendered
> on the black CC box. This is not the intended viewing experience.
> 
> Ignore the leading non-breaking spaces, thus creating the intended
> transparency which aligns the text. Since all characters are
> fixed-width in CC, it can be handled the same way as we currently
> treat leading ordinary spaces.
> 
> Also, as a nit, lowercase the NBSP's hex code in the entry table to match
> casing of the other hex codes.
> 
> Signed-off-by: Marth64 <mart...@proxyid.net>
> ---
>  libavcodec/ccaption_dec.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)

Still LGTM.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Reply via email to