On Wed, Apr 3, 2024 at 10:50 AM 정지우 | Eugene <eug...@bitsensing.com> wrote: > > - typo(1) : Line 242 : RFIC7616 ->RFC7616 > - style(1) : make_digest_auth() , make_digest_auth_sha() : A1hash-> a1_hash > and A2hash -> a2_hash > - nit(3) : httpauth.c: Line 245,265,389: > - nit(1) : httpauth.h: Line 85 > > Signed-off-by: Eugene-bitsensing <eug...@bitsensing.com> > > @@ -386,7 +386,7 @@ char *ff_http_auth_create_response(HTTPAuthState *state, > const char *auth, > if ((password = strchr(username, ':'))) { > *password++ = 0; > /* add digest algorithm SHA-256 */ > - if (!strcmp(state->digest_params.algorithm, "SHA-256")) { > + if (!strcmp(state->digest_params.algorithm, "SHA256")) {
This is not a "nit", "SHA-256" with a dash is how RFC 7616 specifies the algorithm token to be spelled. > authstr = make_digest_auth_sha(state, username, password, > path, method,"SHA256"); > } else { > authstr = make_digest_auth(state, username, password, path, > method); - Hendrik _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".