> -----Original Message----- > From: ffmpeg-devel <ffmpeg-devel-boun...@ffmpeg.org> On Behalf Of Zhao > Zhili > Sent: Sunday, April 28, 2024 6:55 PM > To: FFmpeg development discussions and patches <ffmpeg- > de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH WIP 0/9] Refactor DNN > > > > > On Apr 28, 2024, at 18:34, Guo, Yejun <yejun.guo-at- > intel....@ffmpeg.org> wrote: > > > >> -----Original Message----- > >> From: ffmpeg-devel <ffmpeg-devel-boun...@ffmpeg.org > >> <mailto:ffmpeg-devel-boun...@ffmpeg.org>> On Behalf Of Zhao Zhili > >> Sent: Sunday, April 28, 2024 12:42 AM > >> To: ffmpeg-devel@ffmpeg.org <mailto:ffmpeg-devel@ffmpeg.org> > >> Cc: Zhao Zhili <zhiliz...@tencent.com <mailto:zhiliz...@tencent.com>> > >> Subject: [FFmpeg-devel] [PATCH WIP 0/9] Refactor DNN > >> > >> From: Zhao Zhili <zhiliz...@tencent.com> > >> > >> During the refactor progress, I have found some serious issues, which > >> is not resolved by the patchset: > >> > >> 1. Tensorflow backend is broken. > >> > >> I think it doesn't work since 2021 at least. For example, it destroy > >> a thread and create a new thread for each frame, and it destroy an > >> invalid thread at the first > >> frame: > > > > It works from the day that code is merged, till today. It is by design > > to keep the code simplicity by using the feature that pthread_join > > accepts a parameter that is not a joinable thread. > > > > Please share more info if you experienced a real case that it does not work. > > It will abort if ASSERT_LEVEL > 1. > > #define ASSERT_PTHREAD_ABORT(func, ret) do { \ > char errbuf[AV_ERROR_MAX_STRING_SIZE] = ""; \ > av_log(NULL, AV_LOG_FATAL, AV_STRINGIFY(func) \ > " failed with error: %s\n", \ > av_make_error_string(errbuf, AV_ERROR_MAX_STRING_SIZE, \ > AVERROR(ret))); \ > abort(); \ > } while (0) > > I think the check is there just to prevent call pthread_join(0, &ptr) by > accident, > so we shouldn’t do that on purpose. > Nice catch with configure assert level > 1, will fix, and patch also welcome, thanks. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
