On Fri, May 10, 2024 at 10:56 AM Zhao Zhili <quinkbl...@foxmail.com> wrote:
> From: Zhao Zhili <zhiliz...@tencent.com> > > The alignment is handled by ff_default_get_video_buffer2. We > shouldn't use the aligned width/height as FFFramePool width/height. > It cause recreate FFFramePool inside ff_default_get_video_buffer2. > The recreate of FFFramePool together with multi-threads decoding > leading to data race and crash, for example, > ./ffplay -f lavfi -i movie=foo.mp4,drawtext=text=bar > --- > libavfilter/src_movie.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/libavfilter/src_movie.c b/libavfilter/src_movie.c > index e2cdcf17db..5099012100 100644 > --- a/libavfilter/src_movie.c > +++ b/libavfilter/src_movie.c > @@ -187,7 +187,6 @@ static int get_buffer(AVCodecContext *avctx, AVFrame > *frame, int flags) > > switch (avctx->codec_type) { > case AVMEDIA_TYPE_VIDEO: > - avcodec_align_dimensions2(avctx, &w, &h, linesize_align); > Left unused linesize_align[]. With locking introduced, cant you remove copy check hack above and force new_pool every time? > new = ff_default_get_video_buffer(outlink, w, h); > break; > case AVMEDIA_TYPE_AUDIO: > -- > 2.42.0 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".