On Fri, Jul 31, 2015 at 02:18:07PM -0300, James Almer wrote: > Signed-off-by: James Almer <jamr...@gmail.com> > --- > doc/APIchanges | 3 +++ > libavutil/blowfish.c | 15 +++++++++++++++ > libavutil/blowfish.h | 10 ++++++++++ > libavutil/version.h | 5 ++++- > 4 files changed, 32 insertions(+), 1 deletion(-) [...] > @@ -30,12 +31,21 @@ > * @{ > */ > > +#if FF_API_CRYPTO_CONTEXT > #define AV_BF_ROUNDS 16 > > typedef struct AVBlowfish { > uint32_t p[AV_BF_ROUNDS + 2]; > uint32_t s[4][256]; > } AVBlowfish; > +#else > +typedef struct AVBlowfish AVBlowfish; > +#endif
Is it intended to remove all means to allocate the context on the stack ? this would avoid dealing with malloc/free and malloc failure handling and could be a signifiant advantage also if any usecase is in a API that lacks the possibility to fail, like maybe some crypto callbacks with "void return" [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Into a blind darkness they enter who follow after the Ignorance, they as if into a greater darkness enter who devote themselves to the Knowledge alone. -- Isha Upanishad
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel