On Fri, 7 Jun 2024 at 19:55, Rémi Denis-Courmont <r...@remlab.net> wrote: > > > > Le 7 juin 2024 12:53:51 GMT+03:00, Michael Niedermayer > <mich...@niedermayer.cc> a écrit : > >We can require anything from an API that we are able to change and extend > >Of course we can decide not to allow such requirment even if optional > >but we surely _could_ add such a feature if we choose to do so > > Sure. You can also require infinite memory or an oracle be provided. That's > just not going to happen though. And having libraries depend on the main > thread is a well-documented malpractice. > > I don't think we should add maintenance burden with code that can't be used > safely.
Thank you all for your attention to this patch; I greatly appreciate it. I'd like to provide a brief recap of the issue we've been discussing, with the following points: 1. Addition of sink type in the filter: This enhancement is primarily based on the existing avfilter mechanism and serves as a strengthening module. Using SDL as the sink doesn't seem to be a good fit, as I'll attempt to rectify in the following patch. https://patchwork.ffmpeg.org/project/ffmpeg/patch/20240611130310.1131755-1-hiccup...@gmail.com/ 2. Utilizing SDL as an implementation for the sink: Before submitting the patch, I hadn't considered many aspects. During the intense discussions, I retested the patch on different operating systems, with the following results, hoping it may assist those interested in this issue: Command: ./ffmpeg -lavfi "testsrc2=size=300x200:rate=25:duration=500,format=yuv420p,sdlvsink" -f null /dev/null Test1 Ubuntu 22.04 32GB test result: SUCCESS Test2 Win11 16GB test result: SUCCESS Test3 MacOS 14.4 16GB test result: FAILED Additional notes: In Test2, slight block occurred when resizing the window, possibly due to the lack of Windows message handling mechanism, solely compensated by SDL_PollEvent. I haven't delved deeper into this; if anyone knows the exact reason, please feel free to add. In Test3, direct crash occurred, indicating a segmentation fault. In conclusion: Due to differences in how graphical interfaces are implemented on different platforms, the usage of SDL varies (such as init and render must be on the main thread). Handling such differences at the application level might be more flexible and less suitable for inclusion in general-purpose libraries like ffmpeg. Finally, I'd like to extend my gratitude to everyone for their valuable contributions and insights. > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
