When ret is checked here, it was never assigned anything, making this
check useless, as highlighted by Coverity.
It seems to be a copy paste mistake given that opt_match_per_stream_str
does not return an error code that could be checked and the previous
value assigned to ret is already checked above. So just remove this
check.
Fixes: CID1616292
---
fftools/ffmpeg_mux_init.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c
index e84fa9719f..6aae1add02 100644
--- a/fftools/ffmpeg_mux_init.c
+++ b/fftools/ffmpeg_mux_init.c
@@ -1198,8 +1198,6 @@ static int ost_add(Muxer *mux, const OptionsContext *o,
enum AVMediaType type,
const char *format = "{fidx} {sidx} {n} {t}";
opt_match_per_stream_str(ost, &o->enc_stats_pre_fmt, oc, st,
&format);
- if (ret < 0)
- goto fail;
ret = enc_stats_init(ost, &ost->enc_stats_pre, 1, enc_stats_pre,
format);
if (ret < 0)
base-commit: e26276d829cc608fc95734969bfcf93c3d90162e
--
2.39.3 (Apple Git-146)
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
