> "mov_write_uncC_tag() doesn't seem to be called from anywhere"
Yes, I wanted to divide my contributions up into small sections that are
easy to review. However, this means that each contribution isn't a full
implementation which is why mov_write_uncC_tag() isn't called yet. Is this
an appropriate approach?
As suggested, this next patch uses av_pix_fmt_desc_get() to get the
nb_components
What is considered sufficient for testing? Is this done by running fate?
On Wed, Oct 2, 2024 at 8:37 AM Tomas Härdin <g...@haerdin.se> wrote:
> tis 2024-10-01 klockan 18:53 -0600 skrev Devon Sookhoo:
> > Hello,
> >
> > I attached the .patch so hopefully this is easier for you to apply.
> > The
> > patch itself isn't very impressive, but is intended to be the first
> > of a
> > series of contributions to generate uncompressed MP4 video. I'm
> > hoping to
> > spark interest and receive some guidance on this task moving forward.
>
> mov_write_uncC_tag() doesn't seem to be called from anywhere
>
> > + if (version == 1) {
> > + return update_size(pb, pos);
> > + }
>
> This isn't necessary since you fall through to return update_size(pb,
> pos); further down
>
> If you use information from av_pix_fmt_desc_get() then you could
> support multiple pixel formats instead of just RGB
>
> Tests are also needed
>
> /Tomas
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
>
read_nb_components.patch
Description: Binary data
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
