On Mon, 31 Mar 2025, Niklas Haas wrote:

From: Niklas Haas <g...@haasn.dev>

This was changed 8 years ago with the introduction of the linux-perf path,
with seemingly no justification at the time. Likely a developer oversight
from testing.

This bug not only made --runs completely ineffective, but also meant that we
didn't actually correctly filter out outliers.

Fixes: e0d56f097f42bcdbe6c3b2f57df62a4da63f2094
---
tests/checkasm/checkasm.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/checkasm/checkasm.h b/tests/checkasm/checkasm.h
index ede45bcc2a..922e134bfd 100644
--- a/tests/checkasm/checkasm.h
+++ b/tests/checkasm/checkasm.h
@@ -365,8 +365,8 @@ typedef struct CheckasmPerf {
                }\
            }\
            emms_c();\
-            perf->cycles += t;\
-            perf->iterations++;\
+            perf->cycles += tsum;\
+            perf->iterations += tcount;\
            checkasm_set_signal_handler_state(0);\
        }\
    } while (0)
--
2.48.1

LGTM, thanks for catching this!

// Martin

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Reply via email to