On Wed, 2 Apr 2025, softworkz . wrote:
Hello everybody,
with freshly gained push access rights, I want to act responsibly and
carefully, and also avoid unexpected surprises so I'm not going to rush
things. Due to that change, I thought it might be good to post an
overview of the patchsets I am intending to push in the near future:
Thanks for the heads up.
[...]
avutil/log: Replace addresses in log output with simple ids
GitHub: https://github.com/ffstaging/FFmpeg/pull/59
Patchwork: https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=14094
To be honest, I don't like this at all. You duplicate a lot of code from
avutil/log, and the implementation has quite a few problems, some of them
not really fixable.
- creating object IDs in the order the objects log something (what if they
do not? What if it depends on loglevel?)
- tracking object IDs based on their address - objects are
allocated and removed at runtime, it is possible that an address will be
re-used for a different object later on
- linear search of addresses. A long ffmpeg process can constantly create
objects during runtime, eventually completely depleting the pool and
causing an extensive search for all future logs.
So overall I don't think it's worth pursuing this, especially since most
users won't care neither about the ID, nor about the address...
Regards,
Marton
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
