From: softworkz <softwo...@hotmail.com>
When viewing logs, there are situations where it is not entirely
clear whether ffmpeg CLI has exited gracefully. The two primary cases
are
- A crash/segfault has occured
Windows for example doesn't output any message to the calling shell
- The process has been terminated (e.g. killed externally)
Printing a message on exit provides a reliable indication that the
process has exited normally.
Printing the exit code is useful as it usually remains invisible
and unnoticed by users running FFmpeg from a shell.
Signed-off-by: softworkz <softwo...@hotmail.com>
---
fftools/ffmpeg: Log 'EXIT' on exit
When viewing logs, there are situations where it is not entirely clear
whether ffmpeg CLI has exited gracefully. The two primary cases are
* A crash/segfault has occured Windows for example doesn't output any
message to the calling shell
* The process has been terminated (e.g. killed externally)
Printing "EXIT" on exit provides a reliable indication that the process
has exited normally.
Signed-off-by: softworkz softwo...@hotmail.com
Versions
========
V2
==
* Include exit code in exit message as suggested by Marton Balint
Published-As:
https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging-69%2Fsoftworkz%2Fsubmit_exit_message-v2
Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg
pr-ffstaging-69/softworkz/submit_exit_message-v2
Pull-Request: https://github.com/ffstaging/FFmpeg/pull/69
Range-diff vs v1:
1: a9ea4afc19 ! 1: 2d488c126f fftools/ffmpeg: Log 'EXIT' on exit
@@ Metadata
Author: softworkz <softwo...@hotmail.com>
## Commit message ##
- fftools/ffmpeg: Log 'EXIT' on exit
+ fftools/ffmpeg: Log exit code on exit
When viewing logs, there are situations where it is not entirely
clear whether ffmpeg CLI has exited gracefully. The two primary cases
@@ Commit message
Windows for example doesn't output any message to the calling shell
- The process has been terminated (e.g. killed externally)
- Printing "EXIT" on exit provides a reliable indication that the
+ Printing a message on exit provides a reliable indication that the
process has exited normally.
+ Printing the exit code is useful as it usually remains invisible
+ and unnoticed by users running FFmpeg from a shell.
Signed-off-by: softworkz <softwo...@hotmail.com>
@@ fftools/ffmpeg.c: finish:
sch_free(&sch);
-+ av_log(NULL, AV_LOG_INFO, "\n");
-+ av_log(NULL, AV_LOG_INFO, "EXIT\n");
++ av_log(NULL, AV_LOG_VERBOSE, "\n");
++ av_log(NULL, AV_LOG_VERBOSE, "Exiting with exit code %d\n", ret);
+
return ret;
}
fftools/ffmpeg.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
index dc321fb4a2..397bc1f229 100644
--- a/fftools/ffmpeg.c
+++ b/fftools/ffmpeg.c
@@ -1012,5 +1012,8 @@ finish:
sch_free(&sch);
+ av_log(NULL, AV_LOG_VERBOSE, "\n");
+ av_log(NULL, AV_LOG_VERBOSE, "Exiting with exit code %d\n", ret);
+
return ret;
}
base-commit: 853e66a0726b0a9d6d6269a22f6f9b5be7763738
--
ffmpeg-codebot
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
