> -----Original Message-----
> From: Stefano Sabatini <stefa...@gmail.com>
> Sent: Montag, 21. April 2025 18:14
> To: FFmpeg development discussions and patches <ffmpeg-
> de...@ffmpeg.org>
> Cc: softworkz <softwo...@hotmail.com>
> Subject: Re: [FFmpeg-devel] [PATCH v3] fftools/ffprobe: Print size of
> attachments
>
> On date Sunday 2025-04-20 20:15:41 +0000, softworkz wrote:
> > From: softworkz <softwo...@hotmail.com>
> >
> > Signed-off-by: softworkz <softwo...@hotmail.com>
> > ---
> > fftools/ffprobe: Print size of attachments
> >
> >
> > Versions
> > ========
> >
> > V2
> >
> > Fix spurious commit message text as noted by Andreas (thanks!)
> >
> > V3
> >
> > Also removed from the cover-letter part
> >
> > Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-
> ffstaging-71%2Fsoftworkz%2Fsubmit_attachment_size-v3
> > Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr-
> ffstaging-71/softworkz/submit_attachment_size-v3
> > Pull-Request: https://github.com/ffstaging/FFmpeg/pull/71
> >
> > Range-diff vs v2:
> >
> > 1: dd35a56e25 = 1: b3456eb9f6 fftools/ffprobe: Print size of
> attachments
> >
> >
> > doc/ffprobe.xsd | 3 +++
> > fftools/ffprobe.c | 4 ++++
> > 2 files changed, 7 insertions(+)
> >
> > diff --git a/doc/ffprobe.xsd b/doc/ffprobe.xsd
> > index b53b799227..8c2326e499 100644
> > --- a/doc/ffprobe.xsd
> > +++ b/doc/ffprobe.xsd
> > @@ -319,6 +319,9 @@
> > <xsd:attribute name="nb_frames" type="xsd:int"/>
> > <xsd:attribute name="nb_read_frames" type="xsd:int"/>
> > <xsd:attribute name="nb_read_packets" type="xsd:int"/>
> > +
> > + <!-- attachment attributes -->
> > + <xsd:attribute name="attachment_size" type="xsd:int"/>
> > </xsd:complexType>
> >
> > <xsd:complexType name="programType">
> > diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c
> > index f5c83925b9..0da44b8c49 100644
> > --- a/fftools/ffprobe.c
> > +++ b/fftools/ffprobe.c
> > @@ -1847,6 +1847,10 @@ static int show_stream(AVTextFormatContext
> *tfc, AVFormatContext *fmt_ctx, int s
> > else
> > print_str_opt("height", "N/A");
> > break;
> > +
>
> > + case AVMEDIA_TYPE_ATTACHMENT:
> > + if (par->extradata_size)
> > + print_int("attachment_size", par->extradata_size);
>
> Would it make sense to print the extradata_size in each case to make
> this more generic?
Ohh - my bad. I had done exactly that 3 years ago already, but what
I was using is the "attachment_size from a different patch.
Sorry about that, this patch is obsolete.
Best,
sw
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
