> -----Original Message----- > From: ffmpeg-devel <ffmpeg-devel-boun...@ffmpeg.org> On Behalf Of > Nicolas George > Sent: Montag, 21. April 2025 19:21 > To: FFmpeg development discussions and patches <ffmpeg- > de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v4 02/11] fftools/textformat: > Quality improvements > > Stefano Sabatini (HE12025-04-21): > > > + if (!pwctx || !avio_ctx) > > > + return AVERROR(EINVAL); > > > + > > maybe warning in this case as well > > Checking that an argument that must not be null is not null is the > responsibility of the caller: crashing here is the right thing to do, > same as fprintf(NULL, "fmt"). > > Therefore, an assertion is the best choice. > > Regards, > > -- > Nicolas George > _______________________________________________ Okay, I'll do that. Thank you. sw _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
- Re: [FFmpeg-devel] [PATCH v3 11/11] fftools/graph... Michael Niedermayer
- [FFmpeg-devel] [PATCH v3 02/11] fftools/textformat: Qu... softworkz
- [FFmpeg-devel] [PATCH v3 04/11] fftools/tf_internal: U... softworkz
- [FFmpeg-devel] [PATCH v3 08/11] fftools/resources: Add... softworkz
- [FFmpeg-devel] [PATCH v3 09/11] fftools/ffmpeg_mux: Ma... softworkz
- [FFmpeg-devel] [PATCH v4 00/11] Execution Graph Printi... ffmpegagent
- [FFmpeg-devel] [PATCH v4 01/11] fftools/textforma... softworkz
- [FFmpeg-devel] [PATCH v4 02/11] fftools/textforma... softworkz
- Re: [FFmpeg-devel] [PATCH v4 02/11] fftools/t... Stefano Sabatini
- Re: [FFmpeg-devel] [PATCH v4 02/11] fftoo... Nicolas George
- Re: [FFmpeg-devel] [PATCH v4 02/11] f... softworkz .
- Re: [FFmpeg-devel] [PATCH v4 02/11] fftoo... softworkz .
- [FFmpeg-devel] [PATCH v4 03/11] fftools/textforma... softworkz
- Re: [FFmpeg-devel] [PATCH v4 03/11] fftools/t... Stefano Sabatini
- Re: [FFmpeg-devel] [PATCH v4 03/11] fftoo... softworkz .
- [FFmpeg-devel] [PATCH v4 04/11] fftools/tf_intern... softworkz
- Re: [FFmpeg-devel] [PATCH v4 04/11] fftools/t... Stefano Sabatini
- Re: [FFmpeg-devel] [PATCH v4 04/11] fftoo... softworkz .
- Re: [FFmpeg-devel] [PATCH v4 04/11] f... softworkz .
- [FFmpeg-devel] [PATCH v4 05/11] fftools/textforma... softworkz
- Re: [FFmpeg-devel] [PATCH v4 05/11] fftools/t... Stefano Sabatini