From: Nuo Mi <nuomi2...@gmail.com> Sent: Donnerstag, 15. Mai 2025 14:49 To: softworkz . <softwo...@hotmail.com> Cc: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Subject: Re: [FFmpeg-devel] [PATCH v2 6/7] checkasm: hevc sao_edge, benchmarking inside the width loop is meaningless
On Thu, May 15, 2025 at 9:05 AM softworkz . <softwo...@hotmail.com<mailto:softwo...@hotmail.com>> wrote: > -----Original Message----- > From: ffmpeg-devel > <ffmpeg-devel-boun...@ffmpeg.org<mailto:ffmpeg-devel-boun...@ffmpeg.org>> On > Behalf Of Nuo Mi > Sent: Samstag, 3. Mai 2025 11:13 > To: ffmpeg-devel@ffmpeg.org<mailto:ffmpeg-devel@ffmpeg.org> > Cc: Nuo Mi <nuomi2...@gmail.com<mailto:nuomi2...@gmail.com>> > Subject: [FFmpeg-devel] [PATCH v2 6/7] checkasm: hevc sao_edge, benchmarking > inside the width loop is meaningless > > --- > tests/checkasm/hevc_sao.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/tests/checkasm/hevc_sao.c b/tests/checkasm/hevc_sao.c > index ad47423f10..f597eb5254 100644 > --- a/tests/checkasm/hevc_sao.c > +++ b/tests/checkasm/hevc_sao.c > @@ -119,21 +119,21 @@ static void check_sao_edge(HEVCDSPContext *h, int > bit_depth) > declare_func(void, uint8_t *dst, const uint8_t *src, ptrdiff_t > stride_dst, > const int16_t *sao_offset_val, int eo, int width, int > height); > > - for (int w = prev_size + 4; w <= block_size; w += 4) { > - randomize_buffers(src0, src1, BUF_SIZE); > - randomize_buffers2(offset_val, OFFSET_LENGTH); > - memset(dst0, 0, BUF_SIZE); > - memset(dst1, 0, BUF_SIZE); > + if (check_func(h->sao_edge_filter[i], "hevc_sao_edge_%d_%d", > block_size, bit_depth)) { > + for (int w = prev_size + 4; w <= block_size; w += 4) { > + randomize_buffers(src0, src1, BUF_SIZE); > + randomize_buffers2(offset_val, OFFSET_LENGTH); > + memset(dst0, 0, BUF_SIZE); > + memset(dst1, 0, BUF_SIZE); > > - if (check_func(h->sao_edge_filter[i], "hevc_sao_edge_%d_%d", > block_size, bit_depth)) { > call_ref(dst0, src0 + offset, stride, offset_val, eo, w, > block_size); > call_new(dst1, src1 + offset, stride, offset_val, eo, w, > block_size); > for (int j = 0; j < block_size; j++) { > if (memcmp(dst0 + j*stride, dst1 + j*stride, > w*SIZEOF_PIXEL)) > fail(); > } > - bench_new(dst1, src1 + offset, stride, offset_val, eo, > block_size, block_size); > } > + bench_new(dst1, src1 + offset, stride, offset_val, eo, > block_size, block_size); > } > } > } > -- Hi Nuo, since you have applied this patch (or 7/7)´today, both FATE builds on Windows (MSVC + GCC) are failing - for all submitted patches. https://patchwork.ffmpeg.org/project/ffmpeg Could you please take a look? Your CI is great!👍 😊 Should fixed by https://patchwork.ffmpeg.org/project/ffmpeg/patch/20250515124603.42691-1-nuomi2...@gmail.com/ Yup that does the trick, tanks for the quick fix. If you could apply it quickly (it’s just affecting tests anyway), then I can try to retrigger the failed builds for the other patches, so that they are getting proper checks results on Patchwork. Thanks sw _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
