On 6/7/2025 12:12 AM, Michael Niedermayer wrote:
> Code like FFMIN(MAX_DURATION_BUFFER_SIZE, avio_size(s->pb)) is not safe
> as FFMIN() is a macro and avio_size() is thus evaluated multiple
> times
> 
> CC: Justin Ruggles <just...@vimeo.com>
> Signed-off-by: Michael Niedermayer <mich...@niedermayer.cc>
> ---
>  libavformat/dhav.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)

LGTM.

I don't think it is "not safe", just unexpected, though.

- Derek
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Reply via email to