Re: [FFmpeg-devel] [PATCH v1] avcodec/apv_encoder: Updated APV encoder to set the encoder output to OAPV_CFG_VAL_AU_BS_FMT_NONE format (the only AU without bitstream format)

[Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-boun...@ffmpeg.org> On Behalf Of James
> Almer
> Sent: piątek, 9 maja 2025 17:11
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH v1] avcodec/apv_encoder: Updated APV
> encoder to set the encoder output to OAPV_CFG_VAL_AU_BS_FMT_NONE
> format (the only AU without bitstream format)
> 
> On 5/9/2025 8:52 AM, Dawid Kozinski wrote:
> > Signed-off-by: Dawid Kozinski <d.kozin...@samsung.com>
> > ---
> >   libavcodec/liboapvenc.c | 12 ++++++++++++
> >   1 file changed, 12 insertions(+)
> >
> > diff --git a/libavcodec/liboapvenc.c b/libavcodec/liboapvenc.c index
> > 0c95489bc9..d338b33e2d 100644
> > --- a/libavcodec/liboapvenc.c
> > +++ b/libavcodec/liboapvenc.c
> > @@ -307,6 +307,18 @@ static av_cold int liboapve_init(AVCodecContext
> *avctx)
> >           return AVERROR_EXTERNAL;
> >       }
> >
> > +    {
> > +        int size, value;
> > +
> > +        value = OAPV_CFG_VAL_AU_BS_FMT_NONE;
> > +        size = 4;
> > +        ret = oapve_config(apv->id, OAPV_CFG_SET_AU_BS_FMT, &value,
> &size);
> > +        if(OAPV_FAILED(ret)) {
> > +            av_log(avctx, AV_LOG_ERROR, "Failed to set config for using 
> > encoder
> output format\n");
> > +            return AVERROR_EXTERNAL;
> > +        }
> > +    }
> > +
> >       apv->ifrms.frm[FRM_IDX].imgb = apv_imgb_create(avctx);
> >       if (apv->ifrms.frm[FRM_IDX].imgb == NULL)
> >           return AVERROR(ENOMEM);
> 
> Before we start adding support for recent API additions, liboapv needs to have
> versioning. See
> https://protect2.fireeye.com/v1/url?k=8526c4a4-dabdfc59-85274feb-
> 000babff317b-2be214fc02c42325&q=1&e=e91a51df-ab42-4926-bc0b-
> f20830c7e3c6&u=https%3A%2F%2Fgithub.com%2FAcademySoftwareFoundatio
> n%2Fopenapv%2Fissues%2F86
> Otherwise, we have no way to ensure certain symbols are present and
> compilation will fail if you don't have the correct git master snapshot.

Versioning for liboapv has been added. Therefore I resubmit this patch on the 
top of patchwork. 


_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".