On Mon, 12 May 2025 at 12:00, ffmpegagent <ffmpegag...@gmail.com> wrote: > > When setting up the new Patchword builders I noticed some issues when > running FATE tests on Windows. Initially I had them suppressed on the > builders, but this patchset should finally fix it. > > softworkz (3): > tests/fate: Fix subtitle fate tests on Windows > tests/source-check: Fix make inclusion-guard check EOL-agnostic
I think ffmpeg repositories should always be checked out with LF line endings, there is nothing that expects those sources to have CRLF. If you like you can set attributes to all files to LF (not only subs), but essentially this should already be done by the user when checking the repository. (autocrlf should be considered harmful, the was bad idea to make git tooling smarter for its own good) > tests/hevc: Fix concat input when running in MSYS2 shell This is more tricky, but frankly, I don't like injecting platform specific workarounds into makefile files like that. Either maintain it yourself or do it in a more generic way, not just in one hevc test, because what if someone else adds a concat test? Do you expect them to know that some MSYS2 specific handling is needed? It shouldn't be. Also if you like to fix "fate paths", it should be done fully. Currently only relative paths are working, because some tests are doing things like "$(input)[bla]" which also trips patch conversion, so full unix path doesn't work, because it won't get converted to Windows one, Windows path doesn't work, because it would be mangled because of not escaped `\`. - Kacper _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
