On Thu, Sep 03, 2015 at 04:19:06PM +0200, wm4 wrote:
> On Thu, 3 Sep 2015 15:55:10 +0200
> Stephan Holljes <klaxa1...@googlemail.com> wrote:
>
> > Signed-off-by: Stephan Holljes <klaxa1...@googlemail.com>
> > ---
> > libavformat/http.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > The assignment had incorrectly placed parentheses which resulted in ret
> > always being > 0.
>
> Stuff like this can go into the commit message too.
>
> > diff --git a/libavformat/http.c b/libavformat/http.c
> > index d3c0b7e..c148a29 100644
> > --- a/libavformat/http.c
> > +++ b/libavformat/http.c
> > @@ -399,7 +399,7 @@ static int http_handshake(URLContext *c)
> > switch (ch->handshake_step) {
> > case LOWER_PROTO:
> > av_log(c, AV_LOG_TRACE, "Lower protocol\n");
> > - if ((ret = ffurl_handshake(cl) > 0))
> > + if ((ret = ffurl_handshake(cl)) > 0)
> > return 2 + ret;
> > if ((ret < 0))
> > return ret;
>
> LGTM
applied
thanks
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Old school: Use the lowest level language in which you can solve the problem
conveniently.
New school: Use the highest level language in which the latest supercomputer
can solve the problem without the user falling asleep waiting.
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
