Hello, Looking for a review for this patch, as it currently breaks WebP decoding and is a 1-line fix.
Thanks, RZ On 8/22/25 13:38, rzumer via ffmpeg-devel wrote: > PR #20316 opened by rzumer > URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20316 > Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20316.patch > > This corrects an error in commit c33f16d, causing the single-symbol special > case to fall through to the no-symbol one and returning AVERROR_INVALIDDATA > instead of a success status code. Since the same commit removes shared logic > between the two special cases, I split them up to simplify it as a follow-up. > > > From c031ae60335ed0f02b5b8c80a069656b68f66b68 Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?Rapha=C3=ABl=20Zumer?= <rzu...@tebako.net> > Date: Fri, 22 Aug 2025 12:44:09 -0400 > Subject: [PATCH 1/2] avcodec/webp: fix incorrectly returning > AVERROR_INVALIDDATA when building Huffman reader > MIME-Version: 1.0 > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encoding: 8bit > > This corrects an error in commit c33f16d. > > Signed-off-by: Raphaël Zumer <rzu...@tebako.net> > --- > libavcodec/webp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavcodec/webp.c b/libavcodec/webp.c > index 56c3ec6d28..a350dff7a7 100644 > --- a/libavcodec/webp.c > +++ b/libavcodec/webp.c > @@ -281,6 +281,7 @@ static int huff_reader_build_canonical(HuffReader *r, > const uint8_t *code_length > r->nb_symbols = 1; > r->simple = 1; > r->simple_symbols[0] = syms[0]; > + return 0; > } > // No symbols > return AVERROR_INVALIDDATA; _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
