Le lun. 29 sept. 2025 à 11:46, Yalda <[email protected]> a écrit : > > Hi Romain, > > My pleasure and thanks for contributing this change. > > I was just wanting to know on this line (tagged in PR comments), if > there are scenarios > where we may only get one of these blocks on segment change and if we need to > also emit it to extradata. > ``` > if (priv->header && priv->comment && priv->setup) { > ``` > The answer may very well be no and that's fine.
I imagine that there could be situations where a partial header could be useful but this would be required for broken files only. I set this up this way to be more cautious for a first approach. I imagine that, once this matures there might be some documented cases of broken file/stream that would help relaxing this with a clear target/reproduction case. > Besides that I am willing to approve then merge after a short couple > days objections period. This sounds great. > The maintainer listed for this file is not active, so I'm not sure > there is anyone in particular we need to wait for. I would be interested to step in for that if that is something advisable. I have worked with the ogg container for a long time. Thanks again, -- Romain _______________________________________________ ffmpeg-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]
