PR #21222 opened by Jan Ekström (jeeb) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21222 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21222.patch
After the full ffmpeg CLI multithreading changes went in, this test started depending on how far the input side read and decoded the input compared to how quickly the output encoded things, causing spurious failures on the CI. To my knowledge all of the failures have so far been valid correct results, but unfortunately FATE's built in checks mostly consist of whether there is a difference against an exact result. This way we still get the CI and valgrind running of the code, but stop its comparison. Reference file is left around so that the previous reference is still available. (cherry picked from commit e54bd7065d024bd3925f80533eae10ef88a5cced) From cb0df9b77db0b11d74b7366c5b94aaf01e266bf0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jan=20Ekstr=C3=B6m?= <[email protected]> Date: Thu, 11 Dec 2025 22:11:07 +0200 Subject: [PATCH] fate/ffmpeg: remove comparison against ref from fix_sub_duration_heartbeat After the full ffmpeg CLI multithreading changes went in, this test started depending on how far the input side read and decoded the input compared to how quickly the output encoded things, causing spurious failures on the CI. To my knowledge all of the failures have so far been valid correct results, but unfortunately FATE's built in checks mostly consist of whether there is a difference against an exact result. This way we still get the CI and valgrind running of the code, but stop its comparison. Reference file is left around so that the previous reference is still available. (cherry picked from commit e54bd7065d024bd3925f80533eae10ef88a5cced) --- tests/fate/ffmpeg.mak | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tests/fate/ffmpeg.mak b/tests/fate/ffmpeg.mak index 0f33c2a0ed..46402905f3 100644 --- a/tests/fate/ffmpeg.mak +++ b/tests/fate/ffmpeg.mak @@ -131,6 +131,11 @@ fate-ffmpeg-fix_sub_duration_heartbeat: CMD = fmtstdout srt -fix_sub_duration \ -c:v mpeg2video -b:v 2M -g 30 -sc_threshold 1000000000 \ -c:s srt \ -f null - +# FIXME: disabling comparison against reference as after ffmpeg multithreading +# went in, this test started depending on how far the input side +# progressed compared to how quickly the output encoded packets, +# causing spurious failures on the CI. +fate-ffmpeg-fix_sub_duration_heartbeat: CMP = null FATE_STREAMCOPY-$(call REMUX, MP4 MOV, EAC3_DEMUXER) += fate-copy-trac3074 fate-copy-trac3074: CMD = transcode eac3 $(TARGET_SAMPLES)/eac3/csi_miami_stereo_128_spx.eac3\ -- 2.49.1 _______________________________________________ ffmpeg-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]
