Hi Michael,

appreciate the prompt review and comments! I've made the changes
and put up a PR:

https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21261

Best,

Leslie

On Mon, Dec 22, 2025, at 10:53 AM, Michael Niedermayer via ffmpeg-devel wrote:
> Hi Leslie
> 
> On Fri, Dec 19, 2025 at 08:11:34AM +0800, LP via ffmpeg-devel wrote:
> >  Hello FFmpeg developers,
> > 
> > This patch adds several new fuzzer targets to the tools/ directory to
> > improve
> 
> can you split this in a patch per fuzzer ?
> 
> also you may want to submit it to forgejo: https://code.ffmpeg.org/
> 
> 
> > test coverage for various components, including libavutil (AVOptions),
> > libavfilter,
> > muxers, network protocols, and the CLI options parsing.
> > 
> > It also introduces tools/run_fuzzer_loop.c, a simple harness that allows
> > running
> > these fuzzers in a loop without requiring a full libFuzzer environment.
> > 
> > I have verified that the new targets compile and run successfully.
> > 
> > Please find the patch attached.
> > 
> > Best,
> > 
> > Leslie
> 
> [...]
> 
> > +    // Fill frame with fuzz data if available
> > +    if (size > 0) {
> > +        int copy_size = size;
> > +        // Naive fill, just copy into first plane
> > +        if (copy_size > frame->buf[0]->size) copy_size = 
> > frame->buf[0]->size;
> 
> FFMIN()
> 
> > +        memcpy(frame->data[0], data, copy_size);
> > +    }
> > +
> 
> > +    ret = av_buffersrc_add_frame(src_ctx, frame);
> > +    if (ret < 0) goto end;
> > +
> > +    // Receive output
> > +    while (1) {
> > +        AVFrame *out = av_frame_alloc();
> > +        ret = av_buffersink_get_frame(sink_ctx, out);
> > +        av_frame_free(&out);
> > +        if (ret < 0) break;
> > +    }
> 
> can be simplified with while(ret >= 0)
> 
> 
> 
> 
> > +
> > +end:
> 
> > +    if (options_str) av_free(options_str);
> 
> the if() is unneeded
> 
> 
> [...]
> 
> -- 
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> 
> Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope
> 
> _______________________________________________
> ffmpeg-devel mailing list -- [email protected]
> To unsubscribe send an email to [email protected]
> 
> 
> *Attachments:*
>  • signature.asc
_______________________________________________
ffmpeg-devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to