PR #21473 opened by add-uos-ffmpeg URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21473 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21473.patch
The -sources and -sinks options were defined with OPT_FUNC_ARG flag, which requires an argument. This caused "Missing argument for option 'sources'" error when running ffprobe -sources without arguments. Removing OPT_FUNC_ARG flag allows these options to work without arguments, listing all available devices, while still supporting optional device name argument for filtering specific devices. >From a7b7c17533d14bf34c7af69ab7b7580a72c062d4 Mon Sep 17 00:00:00 2001 From: zhanghongyuan <[email protected]> Date: Thu, 15 Jan 2026 11:39:41 +0800 Subject: [PATCH] fftools/opt_common: Make -sources/-sinks options work without arguments The -sources and -sinks options were defined with OPT_FUNC_ARG flag, which requires an argument. This caused "Missing argument for option 'sources'" error when running ffprobe -sources without arguments. Removing OPT_FUNC_ARG flag allows these options to work without arguments, listing all available devices, while still supporting optional device name argument for filtering specific devices. --- fftools/opt_common.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fftools/opt_common.h b/fftools/opt_common.h index 2a891cdd89..31179046ff 100644 --- a/fftools/opt_common.h +++ b/fftools/opt_common.h @@ -41,9 +41,9 @@ int show_sources(void *optctx, const char *opt, const char *arg); #if CONFIG_AVDEVICE #define CMDUTILS_COMMON_OPTIONS_AVDEVICE \ - { "sources" , OPT_TYPE_FUNC, OPT_EXIT | OPT_FUNC_ARG | OPT_EXPERT, { .func_arg = show_sources }, \ + { "sources" , OPT_TYPE_FUNC, OPT_EXIT | OPT_EXPERT, { .func_arg = show_sources }, \ "list sources of the input device", "device" }, \ - { "sinks" , OPT_TYPE_FUNC, OPT_EXIT | OPT_FUNC_ARG | OPT_EXPERT, { .func_arg = show_sinks }, \ + { "sinks" , OPT_TYPE_FUNC, OPT_EXIT | OPT_EXPERT, { .func_arg = show_sinks }, \ "list sinks of the output device", "device" }, \ #else -- 2.49.1 _______________________________________________ ffmpeg-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]
