PR #21593 opened by Zhao Zhili (quink) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21593 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21593.patch
A constant named 8 has value 8 is redundant. These constants cannot prevent user from setting other vaues. Just describe valid values in the help message. Signed-off-by: Zhao Zhili <[email protected]> >From 9993f22a00cdf14599b2107c3012a2897c709432 Mon Sep 17 00:00:00 2001 From: Zhao Zhili <[email protected]> Date: Mon, 26 Jan 2026 23:04:02 +0800 Subject: [PATCH] avfilter/vf_mestimate_d3d12: remove redundant mb_size constants A constant named 8 has value 8 is redundant. These constants cannot prevent user from setting other vaues. Just describe valid values in the help message. Signed-off-by: Zhao Zhili <[email protected]> --- libavfilter/vf_mestimate_d3d12.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavfilter/vf_mestimate_d3d12.c b/libavfilter/vf_mestimate_d3d12.c index f4620dbe00..710ba6ff33 100644 --- a/libavfilter/vf_mestimate_d3d12.c +++ b/libavfilter/vf_mestimate_d3d12.c @@ -962,9 +962,7 @@ static const AVFilterPad mestimate_d3d12_outputs[] = { #define FLAGS AV_OPT_FLAG_VIDEO_PARAM|AV_OPT_FLAG_FILTERING_PARAM static const AVOption mestimate_d3d12_options[] = { - { "mb_size", "macroblock size", OFFSET(block_size), AV_OPT_TYPE_INT, {.i64 = 16}, 8, 16, FLAGS, .unit = "mb_size" }, - { "8", "8x8 blocks", 0, AV_OPT_TYPE_CONST, {.i64 = 8}, 0, 0, FLAGS, .unit = "mb_size" }, - { "16", "16x16 blocks", 0, AV_OPT_TYPE_CONST, {.i64 = 16}, 0, 0, FLAGS, .unit = "mb_size" }, + { "mb_size", "macroblock size, only 8 and 16 are supported", OFFSET(block_size), AV_OPT_TYPE_INT, {.i64 = 16}, 8, 16, FLAGS }, { NULL } }; -- 2.52.0 _______________________________________________ ffmpeg-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]
