From d055b69332cf55ba7ab3958db7ff5fb07c77d2b0 Mon Sep 17 00:00:00 2001 From: "Alexander S. Drozdov" Date: Fri, 11 Sep 2015 16:31:44 +1000 Subject: [PATCH] TCP Protocol: fix descriptor leak on listen and interrupt If we try to listen on TCP port and ff_listen() fails on interrupt callback socket (bind) descriptor overwrites and does not closed at all. As a result, we can't rebind to the same port. --- libavformat/tcp.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavformat/tcp.c b/libavformat/tcp.c index bee349e..a9af5f8 100644 --- a/libavformat/tcp.c +++ b/libavformat/tcp.c @@ -132,11 +132,11 @@ static int tcp_open(URLContext *h, const char *uri, int flags) goto fail1; } else if (s->listen == 1) { // single client - if ((fd = ff_listen_bind(fd, cur_ai->ai_addr, cur_ai->ai_addrlen, - s->listen_timeout, h)) < 0) { - ret = fd; + if ((ret = ff_listen_bind(fd, cur_ai->ai_addr, cur_ai->ai_addrlen, + s->listen_timeout, h)) < 0) goto fail1; - } + // Socket descriptor already closed here. Safe to overwrite to client one. + fd = ret; } else { if ((ret = ff_listen_connect(fd, cur_ai->ai_addr, cur_ai->ai_addrlen, s->open_timeout / 1000, h, !!cur_ai->ai_next)) < 0) { -- 1.9.1