PR #22429 opened by Nariman-Sayed URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/22429 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/22429.patch
The rtcp-fb SDP attribute was missing the required colon separator between "rtcp-fb" and the payload type, violating RFC 4585 section 4 which defines the syntax as: a=rtcp-fb:<pt> <val> This may cause SDP rejection by strict WebRTC implementations. Signed-off-by: Nariman-Sayed <[email protected]> >From 9b0f8b2ef7da35498e198e33aefaf9d172673ec0 Mon Sep 17 00:00:00 2001 From: Nariman-Sayed <[email protected]> Date: Sat, 7 Mar 2026 08:02:46 +0200 Subject: [PATCH] avformat/whip: fix missing colon in rtcp-fb SDP attribute The rtcp-fb SDP attribute was missing the required colon separator between "rtcp-fb" and the payload type, violating RFC 4585 section 4 which defines the syntax as: a=rtcp-fb:<pt> <val> This may cause SDP rejection by strict WebRTC implementations. Signed-off-by: Nariman-Sayed <[email protected]> --- libavformat/whip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/whip.c b/libavformat/whip.c index fda5fed40c..ba3ebee7d7 100644 --- a/libavformat/whip.c +++ b/libavformat/whip.c @@ -707,7 +707,7 @@ static int generate_sdp_offer(AVFormatContext *s) "a=rtcp-rsize\r\n" "a=rtpmap:%u %s/90000\r\n" "a=fmtp:%u level-asymmetry-allowed=1;packetization-mode=1;profile-level-id=%02x%02x%02x\r\n" - "a=rtcp-fb%u nack\r\n" + "a=rtcp-fb:%u nack\r\n" "a=rtpmap:%u rtx/90000\r\n" "a=fmtp:%u apt=%u\r\n" "a=ssrc-group:FID %u %u\r\n" -- 2.52.0 _______________________________________________ ffmpeg-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]
