Hi Marvin & fre3dm4n,
PR #22965 opened by Marvin Scholz (ePirat)
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/22965
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/22965.patch
The `pktpos` denotes the position in the output packet buffer, while `buf_ptr`
is the position in the input buffer. As this payload is ignored, nothing is
written to the output packet so increasing the `pktpos` does not make sense
here, instead the `buf_ptr` has to be increased to advance the input buffer to
the correct position after this OBU.
Sorry for the bug -- yes you are right, it should have been buf_ptr, not pktpos
that needs to be incremented.
This code path wasn't tested because there was no input data to verify it,
because a conforming RTP encoder
SHOULD not send OBU_TILE_DATA, not meant to be an excuse though.
"The temporal delimiter OBU, if present, SHOULD be removed when transmitting, and
MUST be ignored by receivers. Tile list OBUs are not supported. They SHOULD be removed
when transmitted, and MUST be ignored by receivers."
Thanks for the fix.
Chris
--
Chris
_______________________________________________
ffmpeg-devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]
