PR #23149 opened by wangbin URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/23149 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/23149.patch
This reverts commit 1e031d4af713168259ea3fd82c54a25f30b7bada. cflags in test_ld are not excluded for ld, warnings about cflags should be accepted: - lld-link: warning: ignoring unknown argument '-I/xxx' unknown ldflags(--as-needed and -rpath-link) can be filtered in msvc_common_flags >From d95bd3622f68f2f94cdf010e74093b307a36cede Mon Sep 17 00:00:00 2001 From: wangbin <[email protected]> Date: Tue, 19 May 2026 13:55:22 +0800 Subject: [PATCH] Revert "configure: treat unrecognized option warnings as errors in test_ld" This reverts commit 1e031d4af713168259ea3fd82c54a25f30b7bada. cflags in test_ld are not excluded for ld, warnings about cflags should be accepted: - lld-link: warning: ignoring unknown argument '-I/xxx' unknown ldflags(--as-needed and -rpath-link) can be filtered in msvc_common_flags --- configure | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/configure b/configure index 730b4ac46d..53f3a237a9 100755 --- a/configure +++ b/configure @@ -1301,14 +1301,7 @@ test_ld(){ test_$type $($cflags_filter $flags) || return flags=$($ldflags_filter $flags) libs=$($ldflags_filter $libs) - log $ld $LDFLAGS $LDEXEFLAGS $flags $(ld_o $TMPE) $TMPO $libs $extralibs - output=$($ld $LDFLAGS $LDEXEFLAGS $flags $(ld_o $TMPE) $TMPO $libs $extralibs 2>&1) - ret=$? - echo "$output" >> $logfile - # link.exe and lld-link exit 0 even for unrecognized options, emitting - # only a warning (LNK4044 / "ignoring unknown argument"). Treat such - # output as failure so check_ldflags rejects those flags correctly. - test $ret -eq 0 && ! echo "$output" | grep -qE 'LNK4044|lld-link: warning: ignoring unknown argument' + test_cmd $ld $LDFLAGS $LDEXEFLAGS $flags $(ld_o $TMPE) $TMPO $libs $extralibs } check_ld(){ -- 2.52.0 _______________________________________________ ffmpeg-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]
