sön 2026-05-24 klockan 02:59 +0000 skrev abrasive via ffmpeg-devel:
> PR #23216 opened by abrasive
> URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/23216
> Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/23216.patch
> 
> The Saturn Cinepak libraries require that all chunks start on a 32-
> bit
> boundary, presumably for performance reasons: the SH-2 processor used
> doesn't support unaligned 32-bit or 16-bit loads.
> 
> We can easily achieve this by padding all chunks to a multiple of 4
> bytes using zeroes.
> 
> This is not gated behind an option as the overhead is negligible (eg.
> ~0.02% for a 3-minute, 320x224 video at -q:v 50)

I finally got around to testing this. Output works fine on Windows 3.1
in Dosbox.

> +    while (ret & 3)
> +        buf[ret++] = 0;

We could maybe consolidate these little loops into a common "align buf"
function

FATE references need re-generating too, but that's easy to do with make
GEN=1 fate

/Tomas
_______________________________________________
ffmpeg-devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to